Improve decodeMessage: safer error handling and modern ethers imports#1017
Open
zeevick10 wants to merge 1 commit intosemaphore-protocol:mainfrom
Open
Improve decodeMessage: safer error handling and modern ethers imports#1017zeevick10 wants to merge 1 commit intosemaphore-protocol:mainfrom
zeevick10 wants to merge 1 commit intosemaphore-protocol:mainfrom
Conversation
Contributor
JohnGuilding
left a comment
JohnGuilding
left a comment
There was a problem hiding this comment.
Thanks for raising this @zeevick10!
One issue with this change is that returning null in all cases swallows the actual errors which is useful information to the developer
Another pattern is to have tryDothing and doThing where one function fails gracefully and the other throws all errors. But not sure we want to do that here.
@vplasencia what are your thoughts on this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
decodeMessageto handle invalid input gracefully (returnsnullinstead of throwing).ethersv6+ style.